Remove keyboard shortcut from terminal close action #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
approved these changes
May 10, 2024
Let's call that maybe close focused terminal. Not sure why as yet, but running through in the debugger a lot of times the right action is invoked, but it fails to close anything because Thanks @mbien |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove keyboard shortcut from terminal close action due to multiple conflicts.
While testing the dashboard on macOS I noticed that the terminal close action shortcut clashes with the new dashboard action, which sometimes causes issues. The terminal action uses a non-portable registration, and I was going to look at whether this should change. However, while testing I noticed that the binding on Linux and Windows also clashes with the close all documents action.
As this shortcut seems to only work sporadically, often does nothing, and sometimes inadvertently closes all your open documents instead, it seems a good idea to remove it (for now).
Anyone desperate for keyboard control can always remap, or type
exit! 😄